linux-kernel - Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Nov 2015 23:05:27 +0530
From:	Jitendra <jkhasdev@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	mchehab@....samsung.com, devel@...verdev.osuosl.org,
	Jitendra Kumar Khasdev <jitendra.khasdev@...waxsystems.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in
 radio-bcm2048.c



On Wednesday 18 November 2015 10:42 PM, Greg KH wrote:
> On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote:
>> This is a patch to the radio-bcm2048.c file that fixes up a brace warning
>> found by the checkpatch.pl tool.
>>
>> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@...il.com>
>> ---
>>  drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
>> index b10d601..6226e02 100644
>> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
>> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
>> @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
>>  }
>>  
>>  #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check)		\
>> -property_write(prop, signal size, mask, check)				\
>> -property_read(prop, size, mask)
>> +(property_write(prop, signal size, mask, check)				\
>> +property_read(prop, size, mask))
> You didn't even test-build this patch, why not?
>
Greg KH, I have compiled the kernel by following these step:
                1. copied the .config files
                2. make defconfig
                3. make -j6
 It doesn't show me any warning. so I have tested on my side.
--
Thanks and Regards,
Jitendra Kumar Khasdev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/