linux-kernel - Re: [PATCH] ARM: zx: only build power domain code when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7hwptfyzcg.fsf@deeprootsystems.com>
Date:	Wed, 18 Nov 2015 09:46:55 -0800
From:	Kevin Hilman <khilman@...nel.org>
To:	Jun Nie <jun.nie@...aro.org>
Cc:	Arnd Bergmann <arnd@...db.de>, arm@...nel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: zx: only build power domain code when CONFIG_PM=y

Hi Jun,

Jun Nie <jun.nie@...aro.org> writes:

> 2015-11-17 1:01 GMT+08:00 Arnd Bergmann <arnd@...db.de>:
>
>> The newly added zx power domain code causes build errors in
>> some configurations:
>>
>> warning: (PM_RMOBILE && SOC_ZX296702) selects PM_GENERIC_DOMAINS which has
>> unmet direct dependencies (PM)
>> warning: (ARCH_EXYNOS) selects EXYNOS_THERMAL which has unmet direct
>> dependencies (THERMAL && (ARCH_EXYNOS || COMPILE_TEST) && THERMAL_OF)
>> power/domain.c: In function 'genpd_queue_power_off_work':
>> power/domain.c:192:13: error: 'pm_wq' undeclared (first use in this
>> function)
>>   queue_work(pm_wq, &genpd->power_off_work);
>>              ^
>> power/domain.c:192:13: note: each undeclared identifier is reported only
>> once for each function it appears in
>>
>> This ensures we don't try to enable it when CONFIG_PM is
>> disabled, mirroring what we do on most other platforms.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> Fixes: f15107f41282 ("ARM: zx: Add power domains for ZX296702")
>>
>> diff --git a/arch/arm/mach-zx/Kconfig b/arch/arm/mach-zx/Kconfig
>> index 7fdc5bf24f9b..446334a25cf5 100644
>> --- a/arch/arm/mach-zx/Kconfig
>> +++ b/arch/arm/mach-zx/Kconfig
>> @@ -13,7 +13,7 @@ config SOC_ZX296702
>>         select ARM_GLOBAL_TIMER
>>         select HAVE_ARM_SCU if SMP
>>         select HAVE_ARM_TWD if SMP
>> -       select PM_GENERIC_DOMAINS
>> +       select PM_GENERIC_DOMAINS if PM
>>         help
>>           Support for ZTE ZX296702 SoC which is a dual core CortexA9MP
>>  endif
>>
>> Reviewed-by: Jun Nie <jun.nie@...aro.org>

FYI.. Not sure what mailer you're using, but your "reviewd-by" tag (as
well as the first line of some of your other replies) are showing up in
the quoted section of the previous mail, so it's not obvious at first
glance which part is your reply, and which part you're replying to.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/