| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Nov 2015 10:39:23 -0800 From: "Shi, Yang" <yang.shi@...aro.org> To: Tejun Heo <tj@...nel.org> CC: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, linux-mm@...ck.org, linaro-kernel@...ts.linaro.org Subject: Re: [PATCH] writeback: initialize m_dirty to avoid compile warning On 11/18/2015 10:33 AM, Tejun Heo wrote: > Hello, > > On Wed, Nov 18, 2015 at 10:27:32AM -0800, Shi, Yang wrote: >>> This was the main reason the code was structured the way it is. If >>> cgroup writeback is not enabled, any derefs of mdtc variables should >>> trigger warnings. Ugh... I don't know. Compiler really should be >>> able to tell this much. >> >> Thanks for the explanation. It sounds like a compiler problem. >> >> If you think it is still good to cease the compile warning, maybe we could > > If this is gonna be a problem with new gcc versions, I don't think we > have any other options. :( > >> just assign it to an insane value as what Andrew suggested, maybe >> 0xdeadbeef. > > I'd just keep it at zero. Whatever we do, the effect is gonna be > difficult to track down - it's not gonna blow up in an obvious way. > Can you please add a comment tho explaining that this is to work > around compiler deficiency? Sure. Other than this, in v2, I will just initialize m_dirty since compiler just reports it is uninitialized. Thanks, Yang > > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists