linux-kernel - Re: [PATCH V2 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151118.135250.2066223916643044258.davem@davemloft.net>
Date:	Wed, 18 Nov 2015 13:52:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	salil.mehta@...wei.com
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	paul.gortmaker@...driver.com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, catalin.marinas@....com, will.deacon@....com,
	arnd@...db.de, liguozhu@...ilicon.com, yisen.zhuang@...wei.com,
	dingtianhong@...wei.com, zhangfei.gao@...aro.org,
	huangdaode@...ilicon.com, kenneth-lee-2012@...mail.com,
	mehta.salil.lnk@...il.com, xuwei5@...ilicon.com,
	lisheng011@...wei.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, linuxarm@...wei.com, yankejian@...wei.com,
	lipeng321@...wei.com, fengguang.wu@...el.com
Subject: Re: [PATCH V2 net-next 1/5] net:hns: Add support of Hip06 SoC to
 the Hislicon Network Subsystem

From: Salil <salil.mehta@...wei.com>
Date: Wed, 18 Nov 2015 02:52:23 +0800

> @@ -387,19 +409,23 @@ static void hns_rcb_ring_get_cfg(struct hnae_queue *q, int ring_type)
>  	struct rcb_common_cb *rcb_common;
>  	struct ring_pair_cb *ring_pair_cb;
>  	u32 buf_size;
> -	u16 desc_num;
> -	int irq_idx;
> +	u16 desc_num, mdnum_ppkt;
> +	int irq_idx, is_ver1;

Please use "bool" and true/false for boolean conditions like is_ver1.

Please audit your entire submission for this problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/