linux-kernel - Re: [PATCH] pci: completely disable aspm if it's unsupported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Nov 2015 11:19:02 -0800
From:	Matthew Garrett <mjg59@...eos.com>
To:	Josef Bacik <jbacik@...com>
Cc:	Bjorn Helgaas <helgaas@...nel.org>, linux-pci@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
	shli@...com, kernel-team@...com
Subject: Re: [PATCH] pci: completely disable aspm if it's unsupported

On Wed, Nov 18, 2015 at 11:00 AM, Josef Bacik <jbacik@...com> wrote:
> It looks to me I'm doing what Matthew set out to do, only with a bigger
> hammer ;).  His patch still allowed the initialization of the ASPM stuff,
> like setting up the clocks and such, but then made it so we couldn't change
> the ASPM state at all.  My patch goes the step further of not even doing the
> initialization stuff.  Thanks,

That sounds fine - if we don't gain _OSC control then we should avoid
touching any of the ASPM register state that the firmware has set. I'm
happy to call the current state broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/