lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Nov 2015 23:36:20 +0300 From: Yury Norov <ynorov@...iumnetworks.com> To: Arnd Bergmann <arnd@...db.de> CC: <linux-arm-kernel@...ts.infradead.org>, <catalin.marinas@....com>, <linux-kernel@...r.kernel.org>, <pinskia@...il.com>, <Prasun.Kapoor@...iumnetworks.com>, <schwab@...e.de>, <Nathan_Lynch@...tor.com>, <agraf@...e.de>, <klimov.linux@...il.com>, <broonie@...nel.org>, <jan.dakinevich@...il.com>, <ddaney.cavm@...il.com>, <bamvor.zhangjian@...wei.com>, <philipp.tomsich@...obroma-systems.com>, <andrey.konovalov@...aro.org>, <joseph@...esourcery.com>, <christoph.muellner@...obroma-systems.com> Subject: Re: [PATCH v6 16/19] aarch64: ilp32: use generic stat64 structure On Tue, Nov 17, 2015 at 11:09:05PM +0100, Arnd Bergmann wrote: > On Wednesday 18 November 2015 00:16:56 Yury Norov wrote: > > Generic 32-bit and AARCH32 stat64 structures has same names. > > ILP32 needs generic stat64. So we can either make ILP32 mutual > > exclusive with AARCH32, or duplicate generic cp_new_stat64 code > > and struct stat64 to sys_ilp32.c. We choose second because it's > > more flexible to have independend support for ABIs. > > > > I commented on the previous version, but you have not replied to that, > or changed anything. > > Arnd Hi Arnd, It seems I misunderstood you. Are you OK if we'll enable __ARCH_WANT_COMPAT_STAT64 for ILP32, as for AARCH32_EL0, and turn glibc to use struct stat from sysdeps/unix/sysv/linux/bits/stat.h with this calls? It seems, this is how ARM ABI works. Yury. --- arch/arm64/include/asm/stat.h | 2 -- arch/arm64/include/asm/unistd.h | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/include/asm/stat.h b/arch/arm64/include/asm/stat.h index af04276..15e3559 100644 --- a/arch/arm64/include/asm/stat.h +++ b/arch/arm64/include/asm/stat.h @@ -22,7 +22,6 @@ #include <asm/compat.h> -#ifdef CONFIG_AARCH32_EL0 /* * struct stat64 is needed for compat tasks only. Its definition is different * from the generic struct stat64. @@ -60,4 +59,3 @@ struct stat64 { #endif #endif -#endif diff --git a/arch/arm64/include/asm/unistd.h b/arch/arm64/include/asm/unistd.h index 696e638..3b196f3 100644 --- a/arch/arm64/include/asm/unistd.h +++ b/arch/arm64/include/asm/unistd.h @@ -19,7 +19,6 @@ #endif #ifdef CONFIG_AARCH32_EL0 #define __ARCH_WANT_COMPAT_SYS_GETDENTS64 -#define __ARCH_WANT_COMPAT_STAT64 #define __ARCH_WANT_SYS_GETHOSTNAME #define __ARCH_WANT_SYS_PAUSE #define __ARCH_WANT_SYS_GETPGRP @@ -42,6 +41,7 @@ #define __NR_compat_sigreturn 119 #define __NR_compat_rt_sigreturn 173 +#define __ARCH_WANT_COMPAT_STAT64 #define __ARCH_WANT_SYS_LLSEEK /* -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists