linux-kernel - Re: [PATCH] signal: Unexport sigsuspend()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151118124426.a5d89714ec7102e8066af4e7@linux-foundation.org>
Date:	Wed, 18 Nov 2015 12:44:26 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Richard Weinberger <richard@....at>
Cc:	linux-kernel@...r.kernel.org, vegard.nossum@...cle.com,
	oleg@...hat.com, amanieu@...il.com, dave@...olabs.net,
	qiaowei.ren@...el.com, luto@...capital.net, palmer@...belt.com,
	vdavydov@...allels.com
Subject: Re: [PATCH] signal: Unexport sigsuspend()

On Mon, 16 Nov 2015 19:18:21 +0100 Richard Weinberger <richard@....at> wrote:

> sigsuspend() is nowhere used except in signal.c itself,
> so we can mark it static do not pollute the global namespace.
> 
> But this patch is more than a boring cleanup patch,
> it fixes a real issue on UserModeLinux.
> UML has a special console driver to display ttys using xterm,
> or other terminal emulators, on the host side.
> Vegard reported that sometimes UML is unable to spawn a xterm
> and he's facing the following warning:
> WARNING: CPU: 0 PID: 908 at include/linux/thread_info.h:128 sigsuspend+0xab/0xc0()
> It turned out that this warning makes absolutely no sense as
> the UML xterm code calls sigsuspend() on the host side, at least it tries.
> But as the kernel itself offers a sigsuspend() symbol the linker choose
> this one instead of the glibc wrapper. Interestingly this code used to
> work since ever but always blocked signals on the wrong side.
> Some recent kernel change made the WARN_ON() trigger and uncovered the bug.
> 

So we don't know what caused this or when it started happening.  hrm. 
I guess I'll stick a cc:stable in there as it's likely to affect 4.3
and perhaps earlier, OK?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/