linux-kernel - Re: Anonymous inode cleanup?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA93t1rJzGD8xed_5uLboPHos+dPrj5XVXebbORz7P9LKwi-0Q@mail.gmail.com>
Date:	Wed, 18 Nov 2015 13:10:10 -0800
From:	Rajat Jain <rajatxjain@...il.com>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	linux-fsdevel@...r.kernel.org,
	Davide Libenzi <davidel@...ilserver.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Anonymous inode cleanup?

I see reference taken for the path and module in anon_inode_getfile()

Don't I need to drop that, or would fput() do it for me?

        path_put(&path);
        module_put(fops->owner);

On Wed, Nov 18, 2015 at 1:06 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> On Wed, Nov 18, 2015 at 12:28:38PM -0800, Rajat Jain wrote:
>
>> > _If_ you are returning them via a sucky API, the right sequence is
>> >         reserve the descriptor(s)
>> >         set the file(s) up
>> >         fill whatever structure you'll be using to report descriptors to
>> > userland and copy it to userland memory
>>
>> If this step fails, what is the cleanup needed for "set the files up"
>> anon_inode_getfile() step? is it fput()?
>
> Yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/