linux-kernel - Re: [PATCH 1/2] usb: doc: dwc3-xilinx: Add devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Nov 2015 16:53:31 -0600
From:	Rob Herring <robh@...nel.org>
To:	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>
Cc:	balbi@...com, devicetree@...r.kernel.org,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
Subject: Re: [PATCH 1/2] usb: doc: dwc3-xilinx: Add devicetree bindings

On Wed, Nov 18, 2015 at 06:20:31PM +0530, Subbaraya Sundeep Bhatta wrote:
> This patch adds binding doc for Xilinx DWC3 glue driver.
> 
> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@...inx.com>

I really dislike how the DWC3 binding has been done. The sub-node here 
is pointless. The only thing the outer node does is add clocks which 
should simply be part of the DWC3 node. Presumably the IP block needs 
some clocks...

Anyway, it's self-contained within the DWC3, so I won't make you clean 
up the mess.

Acked-by: Rob Herring <robh@...nel.org>

> ---
>  .../devicetree/bindings/usb/dwc3-xilinx.txt        | 33 ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/dwc3-xilinx.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.txt b/Documentation/devicetree/bindings/usb/dwc3-xilinx.txt
> new file mode 100644
> index 0000000..30361b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/dwc3-xilinx.txt
> @@ -0,0 +1,33 @@
> +Xilinx SuperSpeed DWC3 USB SoC controller
> +
> +Required properties:
> +- compatible:	Should contain "xlnx,zynqmp-dwc3"
> +- clocks:	A list of phandles for the clocks listed in clock-names
> +- clock-names:	Should contain the following:
> +  "bus_clk"	 Master/Core clock, have to be >= 125 MHz for SS
> +		 operation and >= 60MHz for HS operation
> +
> +  "ref_clk"	 Clock source to core during PHY power down
> +
> +Required child node:
> +A child node must exist to represent the core DWC3 IP block. The name of
> +the node is not important. The content of the node is defined in dwc3.txt.
> +
> +Example device node:
> +
> +		usb@0 {
> +			#address-cells = <0x2>;
> +			#size-cells = <0x1>;
> +			status = "okay";
> +			compatible = "xlnx,zynqmp-dwc3";
> +			clock-names = "bus_clk" "ref_clk";
> +			clocks = <&clk125>, <&clk125>;
> +			ranges;
> +
> +			dwc3@...00000 {
> +				compatible = "snps,dwc3";
> +				reg = <0x0 0xfe200000 0x40000>;
> +				interrupts = <0x0 0x41 0x4>;
> +				dr_mode = "host";
> +			};
> +		};
> -- 
> 2.1.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/