linux-kernel - Re: [PATCH] tty/vt/keyboard: use memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA8avJ_VoEi5G9KLnhrY9ULgwQ3q=o8XgqHmMWGNmpBLE=CWVA@mail.gmail.com>
Date:	Thu, 19 Nov 2015 12:48:12 +0530
From:	Saurabh Sengar <saurabh.truth@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>, jslaby@...e.com,
	linux-kernel@...r.kernel.org
Cc:	Saurabh Sengar <saurabh.truth@...il.com>
Subject: Re: [PATCH] tty/vt/keyboard: use memdup_user to simplify code

On 28 October 2015 at 11:56, Saurabh Sengar <saurabh.truth@...il.com> wrote:
> use memdup_user rather than duplicating implementation.
> found by coccinelle
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@...il.com>
> ---
>  drivers/tty/vt/keyboard.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
> index 6f0336f..f973bfc 100644
> --- a/drivers/tty/vt/keyboard.c
> +++ b/drivers/tty/vt/keyboard.c
> @@ -1706,16 +1706,12 @@ int vt_do_diacrit(unsigned int cmd, void __user *udp, int perm)
>                         return -EINVAL;
>
>                 if (ct) {
> -                       dia = kmalloc(sizeof(struct kbdiacr) * ct,
> -                                                               GFP_KERNEL);
> -                       if (!dia)
> -                               return -ENOMEM;
>
> -                       if (copy_from_user(dia, a->kbdiacr,
> -                                       sizeof(struct kbdiacr) * ct)) {
> -                               kfree(dia);
> -                               return -EFAULT;
> -                       }
> +                       dia = memdup_user(a->kbdiacr,
> +                                       sizeof(struct kbdiacr) * ct);
> +                       if (IS_ERR(dia))
> +                               return PTR_ERR(dia);
> +
>                 }
>
>                 spin_lock_irqsave(&kbd_event_lock, flags);
> --
> 1.9.1
>

Hi,

Is this patch rejected for some reason or is still in queue?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/