linux-kernel - Re: [PATCH] mmc: core: set regulator not found message as debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Nov 2015 12:30:04 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Ludovic Desroches <ludovic.desroches@...el.com>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>
Subject: Re: [PATCH] mmc: core: set regulator not found message as debug

On 9 November 2015 at 15:03, Ludovic Desroches
<ludovic.desroches@...el.com> wrote:
> Turn the informative message about no vmmc/vqmmc regulator found in
> debug one. There is no need to indicate that something optional is
> missing. Moreover, it can bring confusion, people who doesn't know
> it is optional may consider these messages as warnings or errors.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@...el.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/core/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 5ae89e4..5b294dd 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1485,7 +1485,7 @@ int mmc_regulator_get_supply(struct mmc_host *mmc)
>         if (IS_ERR(mmc->supply.vmmc)) {
>                 if (PTR_ERR(mmc->supply.vmmc) == -EPROBE_DEFER)
>                         return -EPROBE_DEFER;
> -               dev_info(dev, "No vmmc regulator found\n");
> +               dev_dbg(dev, "No vmmc regulator found\n");
>         } else {
>                 ret = mmc_regulator_get_ocrmask(mmc->supply.vmmc);
>                 if (ret > 0)
> @@ -1497,7 +1497,7 @@ int mmc_regulator_get_supply(struct mmc_host *mmc)
>         if (IS_ERR(mmc->supply.vqmmc)) {
>                 if (PTR_ERR(mmc->supply.vqmmc) == -EPROBE_DEFER)
>                         return -EPROBE_DEFER;
> -               dev_info(dev, "No vqmmc regulator found\n");
> +               dev_dbg(dev, "No vqmmc regulator found\n");
>         }
>
>         return 0;
> --
> 2.5.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/