linux-kernel - Re: [PATCH v6 14/19] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mvm37w2p1kj.fsf@hawking.suse.de>
Date:	Thu, 19 Nov 2015 14:21:16 +0100
From:	Andreas Schwab <schwab@...e.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Yury Norov <ynorov@...iumnetworks.com>, catalin.marinas@....com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	pinskia@...il.com, ddaney.cavm@...il.com, jan.dakinevich@...il.com,
	Prasun.Kapoor@...iumnetworks.com,
	christoph.muellner@...obroma-systems.com,
	philipp.tomsich@...obroma-systems.com, broonie@...nel.org,
	andrey.konovalov@...aro.org, Nathan_Lynch@...tor.com,
	agraf@...e.de, bamvor.zhangjian@...wei.com, klimov.linux@...il.com,
	joseph@...esourcery.com
Subject: Re: [PATCH v6 14/19] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

Arnd Bergmann <arnd@...db.de> writes:

> On Wednesday 18 November 2015 00:16:54 Yury Norov wrote:
>> +#define sys_lseek                      sys_llseek
>
> This seems pointless, as there is no sys_lseek

I think it should be the other way round.  Why would you want to use
llseek if you can pass loff_t in a single register?

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@...e.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/