lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <564DCE17.4040500@acm.org>
Date:	Thu, 19 Nov 2015 07:26:47 -0600
From:	Corey Minyard <minyard@....org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [Openipmi-developer] [RESEND PATCH] char: ipmi: Drop owner assignment
 from i2c_driver

Ok, got it this time, queued for 4.5.

Thanks,

-corey

On 11/18/2015 09:56 PM, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>
> ---
>
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  drivers/char/ipmi/ipmi_ssif.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 90e624662257..5f1c3d08ba65 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1959,7 +1959,6 @@ MODULE_DEVICE_TABLE(i2c, ssif_id);
>  static struct i2c_driver ssif_i2c_driver = {
>  	.class		= I2C_CLASS_HWMON,
>  	.driver		= {
> -		.owner			= THIS_MODULE,
>  		.name			= DEVICE_NAME
>  	},
>  	.probe		= ssif_probe,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ