linux-kernel - Re: [PATCH 10/71] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY and CONFIG_ATARI_SCSI_RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564DD18A.40909@suse.de>
Date:	Thu, 19 Nov 2015 14:41:30 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Finn Thain <fthain@...egraphics.com.au>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/71] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY
 and CONFIG_ATARI_SCSI_RESET_BOOT

On 11/18/2015 09:35 AM, Finn Thain wrote:
> The atari_NCR5380.c core driver now takes care of bus reset upon driver
> initialization if required (same as NCR5380.c). Move the Toshiba CD-ROM
> support into the core driver, enabled with a host flag, so that all
> NCR5380 drivers can make use of it.
> 
> Drop the RESET_BOOT macros and the ATARI_SCSI_RESET_BOOT and 
> ATARI_SCSI_TOSHIBA_DELAY Kconfig symbols, which are now redundant.
> 
> Remove the atari_scsi_reset_boot(), mac_scsi_reset_boot() and
> sun3_scsi_reset_boot() routines. None of this duplicated code is needed
> now that all drivers can use NCR5380_maybe_reset_bus().
> 
> This brings atari_scsi, mac_scsi and sun3_scsi into line with all of the
> other NCR5380 drivers.
> 
> The bus reset may raise an interrupt. That would be new behaviour for
> atari_scsi only when CONFIG_ATARI_SCSI_RESET_BOOT=n. The ST DMA interrupt
> is not assigned to atari_scsi at this stage, so
> CONFIG_ATARI_SCSI_RESET_BOOT=y may well be problematic already.
> Regardless, do_reset() now raises and clears the interrupt within
> local_irq_save/restore which should avoid problems.
> 
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
> 
> ---
>  drivers/scsi/Kconfig         |   17 -----------
>  drivers/scsi/NCR5380.c       |   17 +++++++++--
>  drivers/scsi/NCR5380.h       |    1 
>  drivers/scsi/atari_NCR5380.c |   22 +++++++++-----
>  drivers/scsi/atari_scsi.c    |   60 +++++----------------------------------
>  drivers/scsi/mac_scsi.c      |   65 ++++++-------------------------------------
>  drivers/scsi/sun3_scsi.c     |   47 -------------------------------
>  7 files changed, 51 insertions(+), 178 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/