linux-kernel - imx6dl clock setup incorrectness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Nov 2015 16:56:42 +0300
From:	Nikita Yushchenko <nyushchenko@....rtsoft.ru>
To:	"meta-freescale@...toproject.org" <meta-freescale@...toproject.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Gennady Kuznetsov <kuznetsovg@....rtsoft.ru>
Subject: imx6dl clock setup incorrectness

Hi

While working with board with imx6s cpu, with kernel based on linux-imx
imx_3.14.28_1.0.0_ga branch, I noticed this message in boot log:

> failed to set parent of clk gpu2d_core_sel to pll2_pfd1_594m


I looked into it and found that:

- CCM_CBCMR register layout is different between imx6q/imx6d and
imc6dl/imx6s (at least manuals state that)

- clock setup in clk-imx6q.c (that is used both got imx6q/imx6d and
imx6dl/imx6s) creates gpu2d_core_sel clock object as described in imx6q
manual (i.e. using bits 18:19 of CCM_CBCMR register)

- however per imx6dl manual, these bits contain different field
(mlb_sys_sel) on imx6dl/imx6s, and gpu2d_core sel is in bits 8:9

- imx6q has different clock selector, gpu3d_shader_clk_sel, in bits 8:9,
and existing code unconditionally creates gpu3d_shader_clk_sel clock object

- per manual, gpu3d_shader_clk_sel does not exist on imx6qdl/imx6s

- however gpu driver (which also is common between imx6q/imx6d and
imc6dl/imx6s) does use gpu3d_shader_clk which is child of
gpu3d_shader_clk_sel. Which means that it is not possible to simply
change clock object creation code to match manuals.


I'm looking for advice how to fix this situation properly.


Btw situation is the same in mainline kernel - clock setup code in
mainline is moved to drivers/clk/imx/ but still has the same incorrectness.


Nikita
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/