linux-kernel - Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20151119153057.GA12486@ulmo.nvidia.com>
Date:	Thu, 19 Nov 2015 16:30:59 +0100
From:	Thierry Reding <treding@...dia.com>
To:	Andy Yan <andyshrk@...il.com>
CC:	Andy Yan <andy.yan@...k-chips.com>, Rob Herring <robh@...nel.org>,
	<heiko@...ech.de>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <galak@...eaurora.org>,
	<linux@....linux.org.uk>, <linux-rockchip@...ts.infradead.org>,
	<ijc+devicetree@...lion.org.uk>, <pawel.moll@....com>,
	<mark.rutland@....com>, <linux-arm-kernel@...ts.infradead.org>,
	<khilman@...aro.org>, <wxt@...k-chips.com>, <sjg@...omium.org>,
	<benchan@...gle.com>
Subject: Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip
 reboot notifier driver

On Thu, Nov 19, 2015 at 09:39:02PM +0800, Andy Yan wrote:
> Hi Thierry:
> 
> 2015-11-19 20:56 GMT+08:00 Thierry Reding <treding@...dia.com>:
> 
> > On Thu, Nov 19, 2015 at 09:17:37AM +0800, Andy Yan wrote:
> > > Hi Rob:
> > >
> > > On 2015年11月19日 06:59, Rob Herring wrote:
> > > >On Wed, Nov 18, 2015 at 05:53:30PM +0800, Andy Yan wrote:
> > > >>Add devicetree binding document for rockchip reboot nofifier driver
> > > >Just reading the subject this is way too specific to the Linux driver
> > > >needs rather than a h/w description. Please don't create fake DT nodes
> > > >just to bind to drivers. Whatever &pmu is is probably what should have
> > > >the DT node. Let the driver for it create child devices if you need
> > > >that.
> > >
> > >     This is note a fake DT nodes, we really need it to tell the driver
> > >      which register to use to store the reboot mode. Because rockchip
> > >      use different register file to store the reboot mode on different
> > >      platform, on rk3066,rk3188, rk3288,it use  one of the PMU register,
> > on
> > >      the incoming RK3036, it use one of the GRF register, and it use
> > one  of
> > >      the PMUGRF register for arm64 platform rk3368. On the other hand,
> > the
> > >      PMU/GRF/PMUGRF register file are mapped as "syscon", then referenced
> > >      by other DT nodes by phandle. So maybe let it as a separate DT node
> > > here
> > >      is better.
> >
> > In that case you should probably implement a reboot notifier in each of
> > the drivers you list and depending on the generation of the SoC. You can
> > easily parameterize this by matching on the compatible string.
> >
> > Thierry
> >
> 
>  There is no rockchip specific driver for PMU/GRF/PMUGRF register file I
> list above， they
>  use the generic driver “syscon”

Well, just go and write specific drivers, then.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)