linux-kernel - Re: [PATCH 4/4] sched: add trace event for idle injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151119073523.656c2fcb@icelake>
Date:	Thu, 19 Nov 2015 07:35:23 -0800
From:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:	Javi Merino <javi.merino@....com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Len Brown <len.brown@...el.com>,
	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	Paul Turner <pjt@...gle.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH 4/4] sched: add trace event for idle injection

On Thu, 19 Nov 2015 14:39:35 +0000
Javi Merino <javi.merino@....com> wrote:

> > +  
> 
> One minor nit: can you use key=value (i.e. "throttled=%d") instead for
> consistency with the rest of this file?
> 
will do. 
> Other than that, I know that Peter suggested an enum for the action,
> but wouldn't it be better to create an EVENT_CLASS and subclass the
> three actions from it?  Something like:
I agree, it will be more readable in the trace.


thanks you
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/