linux-kernel - Re: [PATCH] w1: w1_process() is not freezable kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1511191645550.20111@pobox.suse.cz>
Date:	Thu, 19 Nov 2015 16:49:41 +0100 (CET)
From:	Jiri Kosina <jikos@...nel.org>
To:	Evgeniy Polyakov <zbr@...emap.net>
cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	GregKH <greg@...ah.com>
Subject: Re: [PATCH] w1: w1_process() is not freezable kthread

On Thu, 5 Nov 2015, Evgeniy Polyakov wrote:

> > I fail to see why this kthread should be freezable at all. There is no way
> > for w1 device to generate new I/O requests that should be written out to
> > filesystem, is it?
> 
> w1 doesn't generate such requests, but it was more to make this thread
> consistent with majority of other threads in the kernel.

Most of which actually don't need freezer at all, and only contribute to 
the overall confusion regarding what kthread freezer is actually for.

It's my long-term goal to fix this situation (and this patch is part of 
some preparatory steps :) ).

> Ok, I'm not against it, Greg please pull this patch into your tree.
> 
> Acked-by: Evgeniy Polyakov <zbr@...emap.net>

Greg, do you plan to take this please? I don't seem to see it in 
linux-next as of today.

Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/