linux-kernel - Re: [PATCH] staging: android: ion: Fixing NULL comparison style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151119173619.GA15443@kroah.com>
Date:	Thu, 19 Nov 2015 09:36:19 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Anjali Menon <cse.anjalimenon@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android: ion: Fixing NULL comparison style

On Thu, Nov 19, 2015 at 10:29:53PM +0530, Anjali Menon wrote:
> Using checkpatch.pl fixed the check.
> 
> CHECK: Comparison to NULL could be written "!data"
> 
> Signed-off-by: Anjali Menon <cse.anjalimenon@...il.com>
> ---
>  drivers/staging/android/ion/compat_ion.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/compat_ion.c b/drivers/staging/android/ion/compat_ion.c
> index a402fda..8a0df9c 100644
> --- a/drivers/staging/android/ion/compat_ion.c
> +++ b/drivers/staging/android/ion/compat_ion.c
> @@ -137,7 +137,7 @@ long compat_ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>  
>  		data32 = compat_ptr(arg);
>  		data = compat_alloc_user_space(sizeof(*data));
> -		if (data == NULL)
> +		if ("!data" == NULL)

I don't think you compiled this code :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/