linux-kernel - Re: [PATCH] clk: add generic driver for fixed rate clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151119202536.GA9332@chokladfabriken.org>
Date:	Thu, 19 Nov 2015 22:25:37 +0200
From:	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
	linux-clk <linux-clk@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: add generic driver for fixed rate clock

On Tue, Nov 17, 2015 at 04:46:29PM +0100, Geert Uytterhoeven wrote:
> Thanks, this is still very useful!
> 
> I stumbled across this old patch while trying to instantiate a fixed rate
> clock from a DT overlay.
> Without this, the clock is never instantiated, as drivers/clk/clk-fixed-rate.c
> uses CLK_OF_DECLARE() :-( With your driver, it works as expected
> (after fixing the modpost complaint, cfr. below).
>

Ah, I'm glad that this old thing was of use to someone else than me ;)

> However, I think that instead of creating a new driver, you should just add
> the meat of clk-generic-fixed.c to clk-fixed-rate.c.

Sure, that sounds reasonable, I'll take a second bat at this patch and do that.

Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/