lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Nov 2015 16:32:23 -0800 From: Doug Anderson <dianders@...omium.org> To: Heiko Stuebner <heiko@...ech.de> Cc: Kishon Vijay Abraham I <kishon@...com>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...eaurora.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>, Romain Perier <romain.perier@...il.com>, Arnd Bergmann <arnd@...db.de>, Lin Huang <hl@...k-chips.com> Subject: Re: [PATCH v3 4/8] phy: rockchip-usb: add compatible values for rk3066a and rk3188 Heiko, On Thu, Nov 19, 2015 at 1:22 PM, Heiko Stuebner <heiko@...ech.de> wrote: > We need custom handling for these two socs in the driver shortly, > so add the necessary compatible values to binding and driver. > > Signed-off-by: Heiko Stuebner <heiko@...ech.de> > --- > Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt | 5 ++++- > drivers/phy/phy-rockchip-usb.c | 2 ++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt > index 826454a..9b37242 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt > +++ b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt > @@ -1,7 +1,10 @@ > ROCKCHIP USB2 PHY > > Required properties: > - - compatible: rockchip,rk3288-usb-phy > + - compatible: matching the soc type, one of > + "rockchip,rk3066a-usb-phy" > + "rockchip,rk3188-usb-phy" > + "rockchip,rk3288-usb-phy" I can never quite keep it straight how this is supposed to work, but since previously only "rockchip,rk3288-usb-phy" was supported and now we have these new compatible strings, I would have expected the new strings to specify the old ones as fallback. That would mean your choices would be: - "rockchip,rk3288-usb-phy" - A real rk3288 - "rockchip,rk3188-usb-phy", "rockchip,rk3288-usb-phy" - A rk3188 with fallback to 3288 driver. - "rockchip,rk3066a-usb-phy", "rockchip,rk3288-usb-phy" - A rk3066a with fallback to 3288 driver. That means that if you land the dts changes without the driver changes that things still work OK. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists