linux-kernel - Re: [PATCH v2 1/2] mtd: nand: atmel_nand: constify atmel_nand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564ED99A.2050502@atmel.com>
Date:	Fri, 20 Nov 2015 16:28:10 +0800
From:	Josh Wu <josh.wu@...el.com>
To:	LABBE Corentin <clabbe.montjoie@...il.com>,
	<computersforpeace@...il.com>, <dwmw2@...radead.org>
CC:	<linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH v2 1/2] mtd: nand: atmel_nand: constify atmel_nand_caps
 structures

Hi, Corentin

Thanks for the patch.

On 11/20/2015 3:45 PM, LABBE Corentin wrote:
> All atmel_nand_caps are never modified, consitify them.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>

Acked-by: Josh Wu <josh.wu@...el.com>

Best Regards,
Josh Wu
> ---
>   drivers/mtd/nand/atmel_nand.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 583cdd9..475c938 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -128,7 +128,7 @@ struct atmel_nand_host {
>   
>   	struct atmel_nfc	*nfc;
>   
> -	struct atmel_nand_caps	*caps;
> +	const struct atmel_nand_caps	*caps;
>   	bool			has_pmecc;
>   	u8			pmecc_corr_cap;
>   	u16			pmecc_sector_size;
> @@ -2304,11 +2304,11 @@ static int atmel_nand_remove(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -static struct atmel_nand_caps at91rm9200_caps = {
> +static const struct atmel_nand_caps at91rm9200_caps = {
>   	.pmecc_correct_erase_page = false,
>   };
>   
> -static struct atmel_nand_caps sama5d4_caps = {
> +static const struct atmel_nand_caps sama5d4_caps = {
>   	.pmecc_correct_erase_page = true,
>   };
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/