| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <564F0ECD.2050109@uclinux.org> Date: Fri, 20 Nov 2015 22:15:09 +1000 From: Greg Ungerer <gerg@...inux.org> To: Chen Gang <xili_gchen_5257@...mail.com>, "vgupta@...opsys.com" <vgupta@...opsys.com>, "dhowells@...hat.com" <dhowells@...hat.com>, "linux@....linux.org.uk" <linux@....linux.org.uk>, "geert@...ux-m68k.org" <geert@...ux-m68k.org>, "jonas@...thpole.se" <jonas@...thpole.se>, Arnd Bergmann <arnd@...db.de>, "abrodkin@...opsys.com" <abrodkin@...opsys.com>, Andrew Morton <akpm@...ux-foundation.org> Cc: "linux-snps-arc@...ts.infradead.org" <linux-snps-arc@...ts.infradead.org>, kernel mailing list <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-m68k@...ts.linux-m68k.org" <linux-m68k@...ts.linux-m68k.org>, "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>, linux@...ts.openrisc.net Subject: Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page Hi Chen, On 19/11/15 05:40, Chen Gang wrote: >>>From ba7c00c4cb976109b6a35812ce9649aaeda81e2d Mon Sep 17 00:00:00 2001 > From: Chen Gang <gang.chen.5i5j@...il.com> > Date: Thu, 19 Nov 2015 03:24:42 +0800 > Subject: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page > > They are not symmetric with each other, neither are used in real world > (can not be found by grep command in source code root directory), so > remove them. > > Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com> Compile and run tested on m68k (MMU and noMMU) targets. No problems found. So for those parts: Acked-by: Greg Ungerer <gerg@...inux.org> Regards Greg > --- > arch/arc/include/asm/page.h | 3 --- > arch/arm/include/asm/page-nommu.h | 3 --- > arch/frv/include/asm/page.h | 3 --- > arch/m68k/include/asm/page_mm.h | 3 --- > arch/m68k/include/asm/page_no.h | 3 --- > arch/openrisc/include/asm/page.h | 3 --- > include/asm-generic/page.h | 3 --- > 7 files changed, 21 deletions(-) > > diff --git a/arch/arc/include/asm/page.h b/arch/arc/include/asm/page.h > index 429957f..adf5cbb 100644 > --- a/arch/arc/include/asm/page.h > +++ b/arch/arc/include/asm/page.h > @@ -13,9 +13,6 @@ > > #ifndef __ASSEMBLY__ > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(paddr) memset((paddr), 0, PAGE_SIZE) > #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) > > diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h > index d1b162a..503f488 100644 > --- a/arch/arm/include/asm/page-nommu.h > +++ b/arch/arm/include/asm/page-nommu.h > @@ -17,9 +17,6 @@ > #define KTHREAD_SIZE PAGE_SIZE > #endif > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(page) memset((page), 0, PAGE_SIZE) > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > diff --git a/arch/frv/include/asm/page.h b/arch/frv/include/asm/page.h > index 8c97068..52ace96 100644 > --- a/arch/frv/include/asm/page.h > +++ b/arch/frv/include/asm/page.h > @@ -8,9 +8,6 @@ > > #ifndef __ASSEMBLY__ > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(pgaddr) memset((pgaddr), 0, PAGE_SIZE) > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h > index 5029f73..e7a1946 100644 > --- a/arch/m68k/include/asm/page_mm.h > +++ b/arch/m68k/include/asm/page_mm.h > @@ -6,9 +6,6 @@ > #include <linux/compiler.h> > #include <asm/module.h> > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > /* > * We don't need to check for alignment etc. > */ > diff --git a/arch/m68k/include/asm/page_no.h b/arch/m68k/include/asm/page_no.h > index ef20916..fa7f32d 100644 > --- a/arch/m68k/include/asm/page_no.h > +++ b/arch/m68k/include/asm/page_no.h > @@ -6,9 +6,6 @@ > extern unsigned long memory_start; > extern unsigned long memory_end; > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(page) memset((page), 0, PAGE_SIZE) > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > diff --git a/arch/openrisc/include/asm/page.h b/arch/openrisc/include/asm/page.h > index 108906f..e613d36 100644 > --- a/arch/openrisc/include/asm/page.h > +++ b/arch/openrisc/include/asm/page.h > @@ -40,9 +40,6 @@ > > #ifndef __ASSEMBLY__ > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(page) memset((page), 0, PAGE_SIZE) > #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) > > diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h > index 37d1fe2..67cfb7d 100644 > --- a/include/asm-generic/page.h > +++ b/include/asm-generic/page.h > @@ -24,9 +24,6 @@ > > #ifndef __ASSEMBLY__ > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > -#define free_user_page(page, addr) free_page(addr) > - > #define clear_page(page) memset((page), 0, PAGE_SIZE) > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > -- > 1.9.3 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists