linux-kernel - Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564F95E1.7030508@broadcom.com>
Date:	Fri, 20 Nov 2015 22:51:29 +0100
From:	Arend van Spriel <arend@...adcom.com>
To:	Kalle Valo <kvalo@...eaurora.org>,
	Florian Fainelli <f.fainelli@...il.com>
CC:	Hauke Mehrtens <hauke@...ke-m.de>,
	<linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <brcm80211-dev-list@...adcom.com>
Subject: Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

On 11/19/2015 08:54 AM, Kalle Valo wrote:
> Florian Fainelli <f.fainelli@...il.com> writes:
>
>> On 18/11/15 11:19, Hauke Mehrtens wrote:
>>> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>>>> Part of reorganising wireless drivers directory and Kconfig. Note that I had to
>>>> edit Makefiles from subdirectories to use the new location.
>>>>
>>>> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>
>>>> ---
>>>
>>> I would prefer to remove the brcm80211 directory in this process and create:
>>> drivers/net/wireless/broadcom/brcmfmac
>>> drivers/net/wireless/broadcom/brcmsmac
>>> drivers/net/wireless/broadcom/brcmutil
>>> drivers/net/wireless/broadcom/include
>>>
>>> This way we have one directory less.
>>
>> Would not that make keeping track of the previous and future history
>> harder for people contributing to these drivers? I could imagine that
>> for Arend and other Broadcom engineers, dealing with a simple level move
>> would be manageable, but having to account for a different directory
>> hierarchy could be a pain.
>>
>> What is the impact on compat-wireless after/before these changes by the way?
>
> It's called backports nowadays :)
>
> But I understood that as long as we have a separate kconfig option for
> the vendor directories (CONFIG_WLAN_VENDOR_*) it should be ok. For 4.3
> we didn't have that for realtek directory and that caused pain for
> backports.

That is my understanding as well.

Regards,
Arend

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/