linux-kernel - Re: [PATCH v5 1/2] usb: dwc2: host: Add missing spinlock in dwc2_hcd_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2B3535C5ECE8B5419E3ECBE30077290901DC3DAFB7@US01WEMBX2.internal.synopsys.com>
Date:	Fri, 20 Nov 2015 22:44:08 +0000
From:	John Youn <John.Youn@...opsys.com>
To:	Douglas Anderson <dianders@...omium.org>,
	John Youn <John.Youn@...opsys.com>,
	"balbi@...com" <balbi@...com>
CC:	Yunzhi Li <lyz@...k-chips.com>,
	Heiko Stübner <heiko@...ech.de>,
	"linux-rockchip@...ts.infradead.org" 
	<linux-rockchip@...ts.infradead.org>,
	Julius Werner <jwerner@...omium.org>,
	"gregory.herrero@...el.com" <gregory.herrero@...el.com>,
	"yousaf.kaukab@...el.com" <yousaf.kaukab@...el.com>,
	"dinguyen@...nsource.altera.com" <dinguyen@...nsource.altera.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 1/2] usb: dwc2: host: Add missing spinlock in
 dwc2_hcd_reset_func()

On 11/20/2015 9:06 AM, Douglas Anderson wrote:
> The dwc2_hcd_reset_func() function is only ever called directly by a
> delayed work function.  As such no locks are already held when the
> function is called.
> 
> Doing a read-modify-write of CPU registers and setting fields in the
> main hsotg data structure is a bad idea without locks.  Let's add
> locks.
> 
> The bug was found by code inspection only.  It turns out that the
> dwc2_hcd_reset_func() is only ever called today if the
> "host_support_fs_ls_low_power" parameter is enabled and no code in
> mainline enables that parameter.  Thus no known issues in mainline are
> fixed by this patch, but it's still probably wise to fix the function.
> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> Changes in v5:
> - New for v5 of the series
> 
>  drivers/usb/dwc2/hcd.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 42b6c5127618..e8924cecc83a 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -2357,13 +2357,19 @@ static void dwc2_hcd_reset_func(struct work_struct *work)
>  {
>  	struct dwc2_hsotg *hsotg = container_of(work, struct dwc2_hsotg,
>  						reset_work.work);
> +	unsigned long flags;
>  	u32 hprt0;
>  
>  	dev_dbg(hsotg->dev, "USB RESET function called\n");
> +
> +	spin_lock_irqsave(&hsotg->lock, flags);
> +
>  	hprt0 = dwc2_read_hprt0(hsotg);
>  	hprt0 &= ~HPRT0_RST;
>  	dwc2_writel(hprt0, hsotg->regs + HPRT0);
>  	hsotg->flags.b.port_reset_change = 1;
> +
> +	spin_unlock_irqrestore(&hsotg->lock, flags);
>  }
>  
>  /*
> 

Acked-by: John Youn <johnyoun@...opsys.com>

John

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/