linux-kernel - Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151120231937.GD7413@malice.jf.intel.com>
Date:	Fri, 20 Nov 2015 15:19:37 -0800
From:	Darren Hart <dvhart@...radead.org>
To:	Azael Avalos <coproscefalo@...il.com>
Cc:	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via
 genetlink

On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote:
> The driver uses genetlink to inform userspace of events generated by
> the system, but the data passed is always zero as there is no data to
> pass, except for the hotkey event.
> 
> This patch propagates the hotkey value via genetlink so userspace can
> make use of it.

Which keys were not working previously?

My concern is that we introduce new events that then get "double handled".

Some more context about the problem experienced and how this resolves it would
be helpful.

Thanks,

> 
> Signed-off-by: Azael Avalos <coproscefalo@...il.com>
> ---
>  drivers/platform/x86/toshiba_acpi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
> index 7f71f8f..63c231a 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -2966,7 +2966,8 @@ static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
>  
>  	acpi_bus_generate_netlink_event(acpi_dev->pnp.device_class,
>  					dev_name(&acpi_dev->dev),
> -					event, 0);
> +					event, (event == 0x80) ?
> +					dev->last_key_event : 0);
>  }
>  
>  #ifdef CONFIG_PM_SLEEP
> -- 
> 2.6.2
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/