linux-kernel - Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGdLNWGvtpag0kSKEYRqWatcebvtpyotbZ0Ww4EwAr33yL0PHw@mail.gmail.com>
Date:	Fri, 20 Nov 2015 17:05:37 -0700
From:	Azael Avalos <coproscefalo@...il.com>
To:	Darren Hart <dvhart@...radead.org>
Cc:	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink

Hi Darren,

2015-11-20 16:19 GMT-07:00 Darren Hart <dvhart@...radead.org>:
> On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote:
>> The driver uses genetlink to inform userspace of events generated by
>> the system, but the data passed is always zero as there is no data to
>> pass, except for the hotkey event.
>>
>> This patch propagates the hotkey value via genetlink so userspace can
>> make use of it.
>
> Which keys were not working previously?

It's not about the keys, but the "extra events" generated, I still do not
know why Toshiba sent system events inside the hotkey event (maybe
they ran out of numbers...).

>
> My concern is that we introduce new events that then get "double handled".
>

Well, the events are already being generated, but they are Toshiba specific
events, the only thing here that changed is that now we pass the hotkey value
to userspace, and as said, some of the system events that were not passed
before and are not handled at all.

A good example here are the 0x1ABE and 0x1ABF events, which fire (on
certain laptops) when the HDD protection level changes and is disabled
respectively.

There a re a lot of unknown events that are being sent as hotkeys, but
I still have to ideintify them :-(

> Some more context about the problem experienced and how this resolves it would
> be helpful.
>
> Thanks,
>

Cheers
Azael


-- 
-- El mundo apesta y vosotros apestais tambien --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/