[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20151121211131.16715ba3@endymion.delvare>
Date: Sat, 21 Nov 2015 21:11:31 +0100
From: Jean Delvare <jdelvare@...e.de>
To: LABBE Corentin <clabbe.montjoie@...il.com>
Cc: wsa@...-dreams.de, linux-i2c@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by
kstrtou8
Hi Corentin,
On Wed, 18 Nov 2015 13:55:56 +0100, LABBE Corentin wrote:
> The simple_strtoul function is marked as obsolete.
> This patch replace it by kstrtou8.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>
Reviewed-by: Jean Delvare <jdelvare@...e.de>
Tested-by: Jean Delvare <jdelvare@...e.de>
Note: when there's a single patch you don't have to send an email with
PATCH 0/1.
> ---
> drivers/i2c/busses/i2c-taos-evm.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
> index 4c7fc2d..f673f5d 100644
> --- a/drivers/i2c/busses/i2c-taos-evm.c
> +++ b/drivers/i2c/busses/i2c-taos-evm.c
> @@ -130,7 +130,13 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr,
> return 0;
> } else {
> if (p[0] == 'x') {
> - data->byte = simple_strtol(p + 1, NULL, 16);
> + /*
> + * voluntarily dropping error code of kstrtou8 since all
> + * error code that it could return are invalid according
> + * to Documentation/i2c/fault-codes
> + */
> + if (kstrtou8(p + 1, 16, &data->byte))
> + return -EPROTO;
> return 0;
> }
> }
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists