linux-kernel - Re: [PATCH] drivers: staging: vme: Fixed code style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1448141893.4505.25.camel@perches.com>
Date:	Sat, 21 Nov 2015 13:38:13 -0800
From:	Joe Perches <joe@...ches.com>
To:	Egor Uleyskiy <egor.ulieiskii@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Manohar Vanga <manohar.vanga@...il.com>,
	Martyn Welch <martyn@...chs.me.uk>,
	Trivial Patch Monkey <trivial@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: vme: Fixed code style issues

On Sat, 2015-11-21 at 23:26 +0200, Egor Uleyskiy wrote:

trivia:
Some might consider this patch fixes too many issues in
one patch and should be broken up into a patch series.

> > diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c
[]
>  	retval = vme_master_set(card->window, 1, card->base, 0x10000, VME_A24,
> -		(VME_SCT | VME_USER | VME_DATA), VME_D16);
> +				(VME_SCT | VME_USER | VME_DATA), VME_D16);

unnecessary parentheses around VME_ constants
> @@ -343,7 +343,7 @@ static int pio2_probe(struct vme_dev *vdev)
>  	retval = vme_irq_request(vdev, card->irq_level, vec,
> -		&pio2_int, (void *)card);
> +				 &pio2_int, (void *)card);

unnecessary cast to (void *) here and in other places.

You could fix these in follow-on patch(es) or revisions
like a patch set of this one.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/