lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Nov 2015 16:37:02 -0800 From: Stephen Boyd <sboyd@...eaurora.org> To: Masahiro Yamada <yamada.masahiro@...ionext.com> Cc: linux-clk@...r.kernel.org, Michael Turquette <mturquette@...libre.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/3] clk: split of_clk_get_parent_name() into two functions On 11/20, Masahiro Yamada wrote: > Currently, there is no function to get the clock name of the given > node. Create a new helper function, of_clk_get_name(). This is > useful to get the clock name where "clock-indices" property is used. > > of_clk_get_name(): get the clock name in the given node > of_clk_get_parent_name(): get the name of the parent clock > > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com> > --- > > I want to use of_clk_get_name() for my clk drivers for my SoCs, > which I will submit later. > > I found this helper function is useful. I don't see how this is useful. Is the new driver so generic it doesn't know what clocks it's outputting? We've been trying to move people away from using clock-output-names, so most likely this sort of information should be conveyed from DT via the compatible string and a table in the driver that matches up the compatible string with the list of clock names. > @@ -3102,7 +3114,6 @@ const char *of_clk_get_parent_name(struct device_node *np, int index) > } > } > > - Noise. Please remove. > of_node_put(clkspec.np); > return clk_name; > } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists