linux-kernel - Re: [PATCH 2/3] clk: iproc: Add support for Cygnus audio clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564FC186.5010608@broadcom.com>
Date:	Fri, 20 Nov 2015 16:57:42 -0800
From:	Ray Jui <rjui@...adcom.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
CC:	Michael Turquette <mturquette@...libre.com>,
	<linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<bcm-kernel-feedback-list@...adcom.com>,
	Simran Rai <ssimran@...adcom.com>
Subject: Re: [PATCH 2/3] clk: iproc: Add support for Cygnus audio clocks



On 11/20/2015 4:21 PM, Stephen Boyd wrote:
> On 11/18, Ray Jui wrote:
>> diff --git a/drivers/clk/bcm/clk-iproc.h b/drivers/clk/bcm/clk-iproc.h
>> index 8988de7..e2a7748 100644
>> --- a/drivers/clk/bcm/clk-iproc.h
>> +++ b/drivers/clk/bcm/clk-iproc.h
>> @@ -194,5 +215,11 @@ void __init iproc_asiu_setup(struct device_node *node,
>>   			     const struct iproc_asiu_div *div,
>>   			     const struct iproc_asiu_gate *gate,
>>   			     unsigned int num_clks);
>> +void __init iproc_audiopll_clk_setup(struct device_node *node,
>> +				const struct iproc_pll_ctrl *pll_ctrl,
>> +				const struct iproc_pll_vco_param *vco,
>> +				unsigned int num_vco_entries,
>> +				const struct iproc_clk_ctrl *clk_ctrl,
>> +				unsigned int num_clks);
>
> We don't need __init in header files. And is this even used or
> defined anywhere?
>

Does it make more sense if I add an incremental patch to remove all of 
the __init in this header?

Ah, this is a mistake. cygnus_audiopll_clk_init is already defined in 
clk-cygnus.c and is meant to call iproc_pll_clk_setup to set up the 
clock. iproc_pll_clk_setup is already declared in this header.

iproc_audiopll_clk_setup should be removed here.

Thanks,

Ray

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/