lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 Nov 2015 18:37:35 +0900 From: Sergey Senozhatsky <sergey.senozhatsky@...il.com> To: Kyeongdon Kim <kyeongdon.kim@....com> Cc: minchan@...nel.org, akpm@...ux-foundation.org, ngupta@...are.org, linux-kernel@...r.kernel.org, sergey.senozhatsky@...il.com, sergey.senozhatsky.work@...il.com Subject: Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc On (11/21/15 11:15), Sergey Senozhatsky wrote: [..] > > with the only nit that the subject should be "try kmalloc() before vmalloc()" > or similar, not "prevent page allocation failure", I think. > Oh, and one more thing > static void zcomp_lz4_destroy(void *private) > { > - kfree(private); > + if (is_vmalloc_addr(private)) > + vfree(private); > + else > + kfree(private); > } static void zcomp_FOO_destroy(void *private) { kvfree(private); } -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists