linux-kernel - Re: [RFC/PATCH 2/3] recordmcount: Record locations of __aeabi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151121101349.GI8644@n2100.arm.linux.org.uk>
Date:	Sat, 21 Nov 2015 10:13:50 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Måns Rullgård <mans@...sr.com>,
	Arnd Bergmann <arnd@...db.de>,
	Nicolas Pitre <nico@...xnic.net>,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [RFC/PATCH 2/3] recordmcount: Record locations of
 __aeabi_{u}idiv() calls on ARM

On Fri, Nov 20, 2015 at 05:23:16PM -0800, Stephen Boyd wrote:
> @@ -452,14 +631,14 @@ static char const *
>  __has_rel_mcount(Elf_Shdr const *const relhdr,  /* is SHT_REL or SHT_RELA */
>  		 Elf_Shdr const *const shdr0,
>  		 char const *const shstrtab,
> -		 char const *const fname)
> +		 char const *const fname, const char *find)
>  {
>  	/* .sh_info depends on .sh_type == SHT_REL[,A] */
>  	Elf_Shdr const *const txthdr = &shdr0[w(relhdr->sh_info)];
>  	char const *const txtname = &shstrtab[w(txthdr->sh_name)];
>  
> -	if (strcmp("__mcount_loc", txtname) == 0) {
> -		fprintf(stderr, "warning: __mcount_loc already exists: %s\n",
> +	if (strcmp(find, txtname) == 0) {
> +		fprintf(stderr, "warning: %s already exists: %s\n", find,

Oh, it's this which has been spewing that silly
	"warning: __mcount_loc already exists"

message thousands of times in my nightly kernel builds (so much so, that
I've had to filter the thing out of the logs.)  Given that this is soo
noisy, I think first we need to get to the bottom of why this program is
soo noisy before we try to make it more functional.

I had assumed that this message was produced by something in the
toolchain, not something in the kernel.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/