linux-kernel - Re: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151123001437.000018a1@localhost>
Date:	Mon, 23 Nov 2015 00:14:37 +0100
From:	Sebastian Herbszt <herbszt@....de>
To:	Saurabh Sengar <saurabh.truth@...il.com>
Cc:	james.smart@...gotech.com, dick.kennedy@...gotech.com,
	JBottomley@...n.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Sebastian Herbszt <herbszt@....de>
Subject: Re: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc

Saurabh Sengar wrote:
> replacing kmalloc and memset by a single call of kzalloc
> 
> Signed-off-by: Saurabh Sengar <saurabh.truth@...il.com>
> ---
> v2 : I didn't got any response for my initial patch,
> I am sending it again on top of latest kernel(today's)
> 
>  drivers/scsi/lpfc/lpfc_els.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index b6fa257..92dd204 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4956,13 +4956,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
>  	if (RDP_NPORT_ID_SIZE !=
>  			be32_to_cpu(rdp_req->nport_id_desc.length))
>  		goto rjt_logerr;
> -	rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> +	rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
>  	if (!rdp_context) {
>  		rjt_err = LSRJT_UNABLE_TPC;
>  		goto error;
>  	}
>  
> -	memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
>  	cmd = &cmdiocb->iocb;
>  	rdp_context->ndlp = lpfc_nlp_get(ndlp);
>  	rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;

Same patch was already sent by Punit Vara on 2015-10-24.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/