lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 22 Nov 2015 11:17:13 +0000 From: Yuval Mintz <Yuval.Mintz@...gic.com> To: Salil Mehta <salil.mehta@...wei.com>, David Miller <davem@...emloft.net>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "pawel.moll@....com" <pawel.moll@....com>, "mark.rutland@....com" <mark.rutland@....com>, "paul.gortmaker@...driver.com" <paul.gortmaker@...driver.com>, "ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>, "galak@...eaurora.org" <galak@...eaurora.org>, "catalin.marinas@....com" <catalin.marinas@....com>, "will.deacon@....com" <will.deacon@....com>, "arnd@...db.de" <arnd@...db.de>, "liguozhu@...ilicon.com" <liguozhu@...ilicon.com>, "yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>, "dingtianhong@...wei.com" <dingtianhong@...wei.com>, "zhangfei.gao@...aro.org" <zhangfei.gao@...aro.org>, "huangdaode@...ilicon.com" <huangdaode@...ilicon.com>, "kenneth-lee-2012@...mail.com" <kenneth-lee-2012@...mail.com>, "mehta.salil.lnk@...il.com" <mehta.salil.lnk@...il.com>, "xuwei5@...ilicon.com" <xuwei5@...ilicon.com>, "lisheng011@...wei.com" <lisheng011@...wei.com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, netdev <netdev@...r.kernel.org>, "linuxarm@...wei.com" <linuxarm@...wei.com> Subject: RE: [PATCH V4 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS > +static netdev_features_t hns_nic_fix_features( > + struct net_device *netdev, netdev_features_t features) { > + struct hns_nic_priv *priv = netdev_priv(netdev); > + > + switch (priv->enet_ver) { > + case AE_VERSION_1: > + features &= ~(NETIF_F_TSO | NETIF_F_TSO6 | > + NETIF_F_HW_VLAN_CTAG_FILTER); > + break; > + default: > + break; > + } > + return features; > +} > + Isn't AE_VERSION_1 something fixed once you publish your features? If it can't be changed, why not simply remove the features from `hw_features' instead of having to implement this ndo? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists