lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 22 Nov 2015 18:18:37 +0530 From: Saurabh Sengar <saurabh.truth@...il.com> To: eli@...lanox.com, dledford@...hat.com, sean.hefty@...el.com, hal.rosenstock@...il.com, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Saurabh Sengar <saurabh.truth@...il.com> Subject: [PATCH] IB/mlx5: fix null dereference removing null dereference Signed-off-by: Saurabh Sengar <saurabh.truth@...il.com> --- is there any better way to fix it ? as if there is no 'x' there is no way we can access 'x->lock' drivers/infiniband/hw/mlx5/qp.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 307bdbc..613a853 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -1064,13 +1064,10 @@ static void mlx5_ib_lock_cqs(struct mlx5_ib_cq *send_cq, struct mlx5_ib_cq *recv } } else { spin_lock_irq(&send_cq->lock); - __acquire(&recv_cq->lock); } } else if (recv_cq) { spin_lock_irq(&recv_cq->lock); - __acquire(&send_cq->lock); } else { - __acquire(&send_cq->lock); __acquire(&recv_cq->lock); } } @@ -1091,15 +1088,12 @@ static void mlx5_ib_unlock_cqs(struct mlx5_ib_cq *send_cq, struct mlx5_ib_cq *re spin_unlock_irq(&recv_cq->lock); } } else { - __release(&recv_cq->lock); spin_unlock_irq(&send_cq->lock); } } else if (recv_cq) { - __release(&send_cq->lock); spin_unlock_irq(&recv_cq->lock); } else { __release(&recv_cq->lock); - __release(&send_cq->lock); } } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists