linux-kernel - Re: [PATCH] staging: comedi: Coding style warning fix for block comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5652EA23.8000703@mev.co.uk>
Date:	Mon, 23 Nov 2015 10:27:47 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Andy Shevchenko <andy.shevchenko@...il.com>,
	Jitendra Kumar Khasdev <jkhasdev@...il.com>
Cc:	hsweeten@...ionengravers.com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jitendra Kumar Khasdev <jitendra.khasdev@...waxsystems.com>
Subject: Re: [PATCH] staging: comedi: Coding style warning fix for block
 comments

On 22/11/15 19:24, Andy Shevchenko wrote:
> On Sun, Nov 22, 2015 at 9:19 PM, Jitendra Kumar Khasdev
> <jkhasdev@...il.com> wrote:
>> This patch is to comedilib.h file that fixes up following warnings
>> reported by checkpatch.pl :
>> I) Block comments use * on subsequent lines
>>
>> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@...il.com>
>> ---
>>   drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++----------------
>>   1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
>> index 56baf85..ccbe17b 100644
>> --- a/drivers/staging/comedi/comedilib.h
>> +++ b/drivers/staging/comedi/comedilib.h
>> @@ -1,20 +1,20 @@
>>   /*
>> -    linux/include/comedilib.h
>
> I don't think the file name is somehow useful here.

To be fair, this patch is merely fixing the comment style, rather than 
changing the contents.  Although I wouldn't mind if this line were 
changed, especially as the existing pathname is wrong.

It could be changed to be just the basename of the header file like this:

  * comedilib.h

which is similar to the header comment in comedidev.h.

>
>
>> -    header file for kcomedilib
>
> Perhaps
>
> * Header file for kcomedilib.

No objections there.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/