lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Nov 2015 11:01:54 +0800 From: "Wu, Songjun" <songjun.wu@...el.com> To: Mark Brown <broonie@...nel.org> CC: <linux-arm-kernel@...ts.infradead.org>, Nicolas Ferre <nicolas.ferre@...el.com>, Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] ASoC: Atmel: ClassD: Set GCK's parent clock On 11/21/2015 02:08, Mark Brown wrote: > On Thu, Nov 19, 2015 at 11:26:30AM +0800, Songjun Wu wrote: >> Set GCK's parent clock as audio clock, make >> sure the GCK's parent clock is audio clock. > >> + ret = clk_set_parent(dd->gclk, dd->aclk); >> + if (ret) { >> + dev_err(dev, "failed to set GCK parent clock: %d\n", ret); >> + return ret; >> + } > > Why are we doing this in the driver? This should be done by whatever > creates the clock tree, not by the driver that uses the clocks - that > way if some future SoC has a different clock tree the driver will > continue to work. > You are right. The GCK's parent clock should be assigned in device tree, not in the driver. The DT binding for classD should be modified to set the GCK's parent clock as audio clock. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists