linux-kernel - Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151123155346.GE3049@mtj.duckdns.org>
Date:	Mon, 23 Nov 2015 10:53:46 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Daniel Wagner <daniel.wagner@...-carit.de>
Cc:	davem@...emloft.net, pablo@...filter.org, kaber@...sh.net,
	kadlec@...ckhole.kfki.hu, daniel@...earbox.net,
	nhorman@...driver.co, lizefan@...wei.com, hannes@...xchg.org,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-team@...com, ninasc@...com
Subject: Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in
 xt_cgroup

On Mon, Nov 23, 2015 at 09:54:32AM +0100, Daniel Wagner wrote:
...
> > [    3.224665] BUG: spinlock bad magic on CPU#1, systemd/1
> > [    3.225653]  lock: cgroup_sk_update_lock+0x0/0x60, .magic: 00000000, .owner: systemd/1, .owner_cpu: 1
> > [    3.227034] CPU: 1 PID: 1 Comm: systemd Not tainted 4.4.0-rc1+ #195
> > [    3.227862] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.8.2-0-g33fbe13 by qemu-project.org 04/01/2014
> > [    3.228906]  ffffffff834a2160 ffff88007c043ad0 ffffffff81551edc ffff88007c028000
> > [    3.229512]  ffff88007c043af0 ffffffff81136868 ffffffff834a2160 ffff88007aff5940
> > [    3.230105]  ffff88007c043b08 ffffffff81136b05 ffffffff834a2160 ffff88007c043b20
> > [    3.230716] Call Trace:
> > [    3.230906]  [<ffffffff81551edc>] dump_stack+0x4e/0x82
> > [    3.231289]  [<ffffffff81136868>] spin_dump+0x78/0xc0
> > [    3.231642]  [<ffffffff81136b05>] do_raw_spin_unlock+0x75/0xd0
> > [    3.232039]  [<ffffffff81bced77>] _raw_spin_unlock+0x27/0x50
> > [    3.232431]  [<ffffffff819b1848>] update_classid_sock+0x68/0x80
> > [    3.232836]  [<ffffffff812855c1>] iterate_fd+0x71/0x150
> > [    3.233197]  [<ffffffff819b1757>] update_classid+0x47/0x80
> > [    3.233571]  [<ffffffff819b17d4>] cgrp_attach+0x14/0x20
> > [    3.233929]  [<ffffffff81188951>] cgroup_taskset_migrate+0x1e1/0x330
> > [    3.234366]  [<ffffffff81188b95>] cgroup_migrate+0xf5/0x190
> > [    3.235130]  [<ffffffff81188da6>] cgroup_attach_task+0x176/0x200
> > [    3.235953]  [<ffffffff8118922d>] __cgroup_procs_write+0x2ad/0x460
> > [    3.236805]  [<ffffffff81189414>] cgroup_procs_write+0x14/0x20
> > [    3.237205]  [<ffffffff81185ae5>] cgroup_file_write+0x35/0x1c0
> > [    3.237600]  [<ffffffff812e25e1>] kernfs_fop_write+0x141/0x190
> > [    3.237998]  [<ffffffff81265e78>] __vfs_write+0x28/0xe0
> > [    3.239554]  [<ffffffff812665ec>] vfs_write+0xac/0x1a0
> > [    3.240308]  [<ffffffff81266f09>] SyS_write+0x49/0xb0
> > [    3.240656]  [<ffffffff81bcfb32>] entry_SYSCALL_64_fastpath+0x12/0x76
> 
> I have enabled a few additional cgroup controllers as well, because I was
> trying to figure out why I only see the 'memory' cgroup controller in 
> cgroup.controllers. pid and io show up but not net_prio or net_cls.
> Not sure why systemd (v227) is not mounting them.

net_prio and net_cls aren't gonna be on the v2 hierarchy.  The match
in this patchset is being introduced to replace them; however, you can
mount them separately on a v1 hierarchy and use the same as before.

> Though, after a while a similar call trace is produced. I guess this
> has nothing to do with the current changes.
> 
> [   11.594536] ------------[ cut here ]------------
> [   11.595274] WARNING: CPU: 1 PID: 1 at kernel/cgroup_pids.c:97 pids_cancel.constprop.6+0x31/0x40()
> [   11.595958] Modules linked in:
> [   11.596199] CPU: 1 PID: 1 Comm: systemd Not tainted 4.4.0-rc1+ #196
> [   11.596689] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.8.2-0-g33fbe13 by qemu-project.org 04/01/2014
> [   11.597632]  ffffffff81f66d8b ffff88007c04bb90 ffffffff8155ccdc 0000000000000000
> [   11.598234]  ffff88007c04bbc8 ffffffff810de202 ffff8800793dda00 ffff88007a096800
> [   11.598877]  ffff88007c04bc80 ffff88007a6b6200 0000000000000001 ffff88007c04bbd8
> [   11.599547] Call Trace:
> [   11.599784]  [<ffffffff8155ccdc>] dump_stack+0x4e/0x82
> [   11.600197]  [<ffffffff810de202>] warn_slowpath_common+0x82/0xc0
> [   11.600705]  [<ffffffff810de2fa>] warn_slowpath_null+0x1a/0x20
> [   11.601208]  [<ffffffff8118e261>] pids_cancel.constprop.6+0x31/0x40
> [   11.601764]  [<ffffffff8118e32d>] pids_can_attach+0x6d/0xf0

Yeah, this is a known problem regarding css's lifetime.  Working on
it.  The earlier dump, I think, is likely to have been caused by the
same issue.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/