linux-kernel - Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3809374.hKy9fQ2ldj@wuerfel>
Date:	Mon, 23 Nov 2015 17:57:28 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	"Andrew F. Davis" <afd@...com>
Cc:	Pali Rohár <pali.rohar@...il.com>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Andreas Dannenberg <dannenberg@...com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module

On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote:
> Separate out I2C functionality into a module. This fixes several small
> issues and simplifies the driver initialization.
> 
> Signed-off-by: Andrew F. Davis <afd@...com>

That looks good to me overall, it should help with the randconfig
warnings I've been seeing and makes the driver structured more logically.

The one part I wonder about is whether the platform_driver portion
should also be split out into a separate module in the same way.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/