lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Nov 2015 15:18:05 +0800 From: Chen-Yu Tsai <wens@...e.org> To: LABBE Corentin <clabbe.montjoie@...il.com> Cc: Alexandre Belloni <alexandre.belloni@...e-electrons.com>, Alessandro Zummo <a.zummo@...ertech.it>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, Maxime Ripard <maxime.ripard@...e-electrons.com>, Chen-Yu Tsai <wens@...e.org>, linux-kernel <linux-kernel@...r.kernel.org>, rtc-linux@...glegroups.com Subject: Re: [PATCH 1/3] rtc: sunxi: fix signedness issues On Thu, Nov 19, 2015 at 6:50 PM, LABBE Corentin <clabbe.montjoie@...il.com> wrote: > The variable year must be set as unsigned since it is used with > sunxi_rtc_data_year{.min|.max} and as parameter of is_leap_year() which > wait for unsigned int. > Only tm_year is not unsigned, but it is long. > This patch fix also the format of printing of min/max. (must use %u since > they are unsigned) > > The parameter to of sunxi_rtc_setaie() must be set to uint since callers > give always uint data. > > Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com> Acked-by: Chen-Yu Tsai <wens@...e.org> Would've preferred you not changing the whitespace on the dev_err line though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists