linux-kernel - Re: MPT2SAS boot fail... due to silently loosing the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151124080429.GA3398@gmail.com>
Date:	Tue, 24 Nov 2015 09:04:29 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Christoph Hellwig <hch@....de>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Sreekanth.Reddy@...gotech.com, hare@...e.de,
	martin.petersen@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: MPT2SAS boot fail... due to silently loosing the driver

* Christoph Hellwig <hch@....de> wrote:

> I wonder what the "classic" way to such transitions is.  Adding a mpt2 option 
> that just selects mpt3 sound easy, but might be very confusing.

I was hit by the same problem, and wasted some time on it before Peter did his 
time wasting, so a solution would be nice.

An interactive SCSI_MPT2SAS option has to exist in any case, so that we can 
migrate those people who have it configured - and its help text should explain 
that it's a legacy setting that should not be used anymore. That won't be 
confusing.

Then the MPT3 section can do something like:

	# Default to enabled if the config has the old driver enabled:
	default y if SCSI_MPT2SAS

Doing this will also help bisectability: right now we cannot bisect on that system 
without figuring out whether to enable MPT2 or MPT3 at every single bisection 
step.

Don't ever break configs this way. Please!

Also, please pick hardware version invariant names - do we want to go through this 
again when MPT4 is introduced?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/