lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Nov 2015 08:48:54 +0800 From: Zain <zain.wang@...k-chips.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: zhengsq@...k-chips.com, hl@...k-chips.com, davem@...emloft.net, mturquette@...libre.com, heiko@...ech.de, pawel.moll@....com, ijc+devicetree@...lion.org.uk, robh+dt@...nel.org, galak@...eaurora.org, linux@....linux.org.uk, mark.rutland@....com, linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org, eddie.cai@...k-chips.com Subject: Re: [PATCH v4 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288 On 2015年11月23日 20:51, Herbert Xu wrote: > On Tue, Nov 17, 2015 at 12:00:46PM +0800, Zain Wang wrote: >> +static void rk_ablk_hw_init(struct rk_crypto_info *dev) >> +{ >> + struct crypto_ablkcipher *tfm = crypto_ablkcipher_reqtfm(dev->ablk_req); >> + struct rk_cipher_ctx *ctx = crypto_ablkcipher_ctx(tfm); >> + u32 conf_reg = 0; >> + >> + if (dev->mode & TDES) { >> + dev->mode &= ~TDES; >> + dev->mode |= RK_CRYPTO_TDES_FIFO_MODE | >> + RK_CRYPTO_TDES_BYTESWAP_KEY | >> + RK_CRYPTO_TDES_BYTESWAP_IV; >> + CRYPTO_WRITE(dev, RK_CRYPTO_TDES_CTRL, dev->mode); >> + >> + memcpy(dev->reg + RK_CRYPTO_TDES_IV_0, dev->ablk_req->info, 8); > Please ensure that the IV is copied back after the operation. > I know that many existing drivers are buggy in this regard but > they will be fixed soon and we will start enforcing this rule > so I don't want to add any new drivers that break this rule. Thanks your responding, I will fix it in v5. > > Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists