linux-kernel - Re: [PATCH v5 0/2] simplefb: Add regulator handling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5654435E.3060202@ti.com>
Date:	Tue, 24 Nov 2015 13:00:46 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Hans de Goede <hdegoede@...hat.com>
CC:	Mark Brown <broonie@...nel.org>, <linux-sunxi@...glegroups.com>,
	<linux-fbdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 0/2] simplefb: Add regulator handling support



On 17/11/15 06:31, Chen-Yu Tsai wrote:
> Hi everyone,
> 
> This is v5 of the simplefb regulator support series. This series adds
> regulator claiming and enabling support for simplefb.
> 
> Hans, I dropped your Reviewed-by tag from patch 2 since v4.
> 
> Changes since v5:
>   - Rebased onto v4.4-rc1
>   - Dropped dts patches (merged)
> 
> Changes since v4:
>   - Fixed inverted logic when testing the property name.
>   - Fixed regulator supply name string copy length off by 1.
>   - Added real world user, MSI Primo 81 dts patches.
> 
> Changes since v3:
>   - Dropped extra "if" which is always true, leftover from v1.
>   - Updated commit message of patch 1
> 
> Sometimes the simplefb display output path consits of external conversion
> chips and/or LCD drivers and backlights. These devices normally have
> GPIOs to turn them on and/or bring them out of reset, and regulators
> supplying power to them.
> 
> While the kernel does not touch unclaimed GPIOs, the regulator core
> happily disables unused regulators. Thus we need simplefb to claim
> and enable the regulators used throughout the display pipeline.
> 
> The binding supports any named regulator supplies under its device
> node. The driver will look through its properties, and claim any
> regulators by matching "*-supply", as Mark suggested.
> 
> I've not done a generic helper in the regulator core yet, instead doing
> the regulator property handling in the simplefb code for now.
> 
> 
> Patch 1 adds the regulator properties to the DT binding.
> 
> Patch 2 adds code to the simplefb driver to claim and enable regulators.
> 
> Regards
> ChenYu
> 
> 
> Chen-Yu Tsai (2):
>   dt-bindings: simplefb: Support regulator supply properties
>   simplefb: Claim and enable regulators
> 
>  .../bindings/display/simple-framebuffer.txt        |  13 ++-
>  drivers/video/fbdev/simplefb.c                     | 120 ++++++++++++++++++++-
>  2 files changed, 128 insertions(+), 5 deletions(-)
> 

Thanks, queued for 4.5.

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)