linux-kernel - RE: PCIe regression with DRA7xx in 4.4-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EE11001F9E5DDD47B7634E2F8A612F2E162C92FB@lhreml503-mbs>
Date:	Tue, 24 Nov 2015 12:08:17 +0000
From:	Gabriele Paoloni <gabriele.paoloni@...wei.com>
To:	Kishon Vijay Abraham I <kishon@...com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"james.morse@....com" <james.morse@....com>,
	"gabriel.fernandez@...com" <gabriel.fernandez@...com>,
	"Minghuan.Lian@...escale.com" <Minghuan.Lian@...escale.com>,
	"Wangzhou (B)" <wangzhou1@...ilicon.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"pratyush.anand@...il.com" <pratyush.anand@...il.com>,
	"Nori, Sekhar" <nsekhar@...com>,
	"jingoohan1@...il.com" <jingoohan1@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: PCIe regression with DRA7xx in 4.4-rc1

Hi Kishon

> -----Original Message-----
> From: Kishon Vijay Abraham I [mailto:kishon@...com]
> Sent: 24 November 2015 12:01
> To: linux-pci@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> omap@...r.kernel.org; james.morse@....com; gabriel.fernandez@...com;
> Minghuan.Lian@...escale.com; Wangzhou (B); Gabriele Paoloni; arnd@...db.de;
> bhelgaas@...gle.com; pratyush.anand@...il.com; Nori, Sekhar;
> jingoohan1@...il.com; linux-arm-kernel@...ts.infradead.org
> Subject: PCIe regression with DRA7xx in 4.4-rc1
> 
> Hi,
> 
> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
> designware: Make driver arch-agnostic").
> 
> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that
> I
> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O
> error, err_mask=0x4)"
> 

May this be related to the bug flagged in:

[PATCH] PCI: designware: remove wrong io_base assignment

[...]
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 540f077c37ea..02a7452bdf23 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp)
 					 ret, pp->io);
 				continue;
 			}
-			pp->io_base = pp->io->start;
 			break;
 		case IORESOURCE_MEM:
 			pp->mem = win->res;
-- 
1.7.9.5
[...]

Can you try to see if applying the patch above solves the issue?

Thanks

Gab

> Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine
> but when I give ifconfig up, it fails.
> 
> If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe
> cards starts to work fine again
> 
> Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine.
> Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now.
> 
> Actually I'm not able to find any obvious problems with the patch and the irq
> number and the memory resource also looks fine. Any idea what could be the
> problem?
> 
> [1] -> http://pastebin.ubuntu.com/13491456/
> [2] -> http://pastebin.ubuntu.com/13491526/
> 
> [3] -> http://pastebin.ubuntu.com/13491658/
> [4] -> http://pastebin.ubuntu.com/13491593/
> 
> Thanks
> Kishon