linux-kernel - Re: [PATCH] mfd: constify da903x_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151124163011.GA12874@x1>
Date:	Tue, 24 Nov 2015 16:30:11 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Support Opensource <support.opensource@...semi.com>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: constify da903x_chip_ops structure

On Fri, 13 Nov 2015, Julia Lawall wrote:

> The da903x_chip_ops structure is never modified, so declare it
> as const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>  drivers/mfd/da903x.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
> index 37e4426..f6a0459 100644
> --- a/drivers/mfd/da903x.c
> +++ b/drivers/mfd/da903x.c
> @@ -60,7 +60,7 @@ struct da903x_chip_ops {
>  struct da903x_chip {
>  	struct i2c_client	*client;
>  	struct device		*dev;
> -	struct da903x_chip_ops	*ops;
> +	const struct da903x_chip_ops *ops;
>  
>  	int			type;
>  	uint32_t		events_mask;
> @@ -424,7 +424,7 @@ static irqreturn_t da903x_irq_handler(int irq, void *data)
>  	return IRQ_HANDLED;
>  }
>  
> -static struct da903x_chip_ops da903x_ops[] = {
> +static const struct da903x_chip_ops da903x_ops[] = {
>  	[0] = {
>  		.init_chip	= da9030_init_chip,
>  		.unmask_events	= da9030_unmask_events,
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/