linux-kernel - Re: [PATCH] reset: ath79: Add system restart support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151124193349.6ddc4c0b@tock>
Date:	Tue, 24 Nov 2015 19:33:49 +0100
From:	Alban <albeu@...e.fr>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	Aban Bedel <albeu@...e.fr>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: ath79: Add system restart support

On Tue, 24 Nov 2015 13:01:46 +0100
Philipp Zabel <p.zabel@...gutronix.de> wrote:

> Hi Alban,
> 
> Am Dienstag, den 24.11.2015, 01:00 +0100 schrieb Alban Bedel:
> > Add a system restart handler that use the FULL_CHIP_RESET bit of the
> > reset controller.
> > 
> > Signed-off-by: Alban Bedel <albeu@...e.fr>
> 
> Applied, thanks.

Thanks to you :)

> Btw, should this driver #include <linux/io.h> for readl/writel?

Good question :) It turns out to be a MIPS glitch, asm/io.h is included
by asm/page.h which here come from linux/module.h. But we shouldn't
rely on this glitch and the driver should #include <linux/io.h>.
I'll fix this and add support for CONFIG_COMPILE_TEST to better catch
this kind of bugs in the future.

Alban
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/