linux-kernel - Re: [PATCH V4] acpi: add support for extended IRQ to PCI link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5654C314.7050201@codeaurora.org>
Date:	Tue, 24 Nov 2015 15:05:40 -0500
From:	Sinan Kaya <okaya@...eaurora.org>
To:	Bjorn Helgaas <helgaas@...nel.org>
Cc:	linux-acpi@...r.kernel.org, timur@...eaurora.org,
	cov@...eaurora.org, jcm@...hat.com,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4] acpi: add support for extended IRQ to PCI link

On 11/24/2015 1:11 PM, Bjorn Helgaas wrote:
> 
> As Andy mentioned, please wrap this text to use more of an 80-column
> line.  I fill changelogs to 75 columns (vi textwidth=75), which fits
> perfectly when "git log" inserts 4 leading spaces.
> 

will do

> 
> These changes are basically all bounds-checking link->irq.possible[i]
> and link->irq.active.  What if you put that checking at the point
> where we *initialize* those fields instead, i.e., in
> acpi_pci_link_check_possible() and acpi_pci_link_get_current()?  Then 
> you'd only have to check each field in one place, and you could easily
> add a message if we see an ID that's too large.
> 

I'll post a patch soon.

> I think the current code for ACPI_RESOURCE_TYPE_EXTENDED_IRQ is buggy
> because it silently truncates IDs to 8 bits.
> 
> Bjorn
> 


-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/