linux-kernel - Re: [PATCH] ASoC: fsl: clarify ac97 dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151124225021.GA4600@Asurada-CZ80>
Date:	Tue, 24 Nov 2015 14:50:21 -0800
From:	Nicolin Chen <nicoleotsuka@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Subject: Re: [PATCH] ASoC: fsl: clarify ac97 dependency

On Tue, Nov 24, 2015 at 11:21:10PM +0100, Arnd Bergmann wrote:
> A new randconfig build failure shows that the fsl-asoc-card module
> must not be built-in when the AC97 driver is a loadable module:
> 
> sound/built-in.o: In function `fsl_asoc_card_late_probe':
> :(.text+0x571d8): undefined reference to `snd_ac97_update_bits'
> 
> I couldn't come up with a nice solution, so this adds another dependency
> on "X || !X", which is the Kconfig way of saying that we have an
> optional dependency on something that might be a loadable module.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Nicolin Chen <nicoleotsuka@...il.com>

Thank you

> Fixes: 50760cad9de9 ("ASoC: fsl-asoc-card: add AC'97 support")
> ---
> The commit that introduced this was merged for 4.4-rc1, so we might
> want the fix to go into 4.4 as well.
> 
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index 19c302b0d763..14dfdee05fd5 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -283,6 +283,8 @@ config SND_SOC_IMX_MC13783
>  config SND_SOC_FSL_ASOC_CARD
>  	tristate "Generic ASoC Sound Card with ASRC support"
>  	depends on OF && I2C
> +	# enforce SND_SOC_FSL_ASOC_CARD=m if SND_AC97_CODEC=m:
> +	depends on SND_AC97_CODEC || SND_AC97_CODEC=n
>  	select SND_SOC_IMX_AUDMUX
>  	select SND_SOC_IMX_PCM_DMA
>  	select SND_SOC_FSL_ESAI
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/