linux-kernel - Re: [PATCH 31/37] perf callchain: Add count fields to struct callchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151124051547.GA2636@sejong>
Date:	Tue, 24 Nov 2015 14:15:47 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Andi Kleen <andi@...stfloor.org>,
	David Ahern <dsahern@...il.com>,
	Kan Liang <kan.liang@...el.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 31/37] perf callchain: Add count fields to struct
 callchain_node

Hi Frederic,

On Mon, Nov 23, 2015 at 03:35:30PM +0100, Frederic Weisbecker wrote:
> Namhyung,
> 
> On Thu, Nov 19, 2015 at 02:53:17PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Namhyung Kim <namhyung@...nel.org>
> > 
> > It's to track the count of occurrences of the callchains.
> 
> Please explain why you do something like this in the changelog, even just a single
> line to tell which feature is going to use this and why.
> 
> No need to resend just for that, it's just for future patches.

OK, I'll keep in mind that.

This patch is a preparation for supporting different callchain value
output style.  Instead of current percent output, it could have period
or count with this change.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/